Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pgadmin remove service #3755

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Pgadmin remove service #3755

merged 2 commits into from
Oct 19, 2023

Conversation

jmckulk
Copy link
Collaborator

@jmckulk jmckulk commented Oct 18, 2023

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

@jmckulk
update kuttl admin username
8b17cf5
@jmckulk
Remove pgAdmin Service
e535d79 
The option to allow a user to create a service through the pgAdmin spec
was pulled over from the v4.30 implentation. We are reevaluating how we
want to handle services and have decided to remove service creation
entirely for this round of pgAdmin changes.
tjmoore4
tjmoore4 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmckulk jmckulk merged commit 4045861 into CrunchyData:master Oct 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjmoore4 tjmoore4 tjmoore4 approved these changes

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmckulk @benjaminjb @tjmoore4